PYR0D-351: Pass the contribution-input backlog to jq as files, not arguments #40

Merged

john merged 2 commits from fm/fm-snapshot-argv-limit into main 2026-10-01 01:19:18 +00:00

Conversation 0 Commits 2 Files changed 2 +30 -2

john commented 2026-09-30 23:25:11 +00:00

Owner

Copy link

Story: PYR0D-351 - Firstmate: session-start fleet snapshot fails with "Argument list too long" on a large backlog

What was wrong

bin/fm-fleet-snapshot.sh --contribution-input handed the whole backlog JSON to jq as a command-line argument (jq -n --argjson backlog "$BACKLOG_JSON" ...). On this home's backlog that one argument is far past the kernel's 128 KiB single-argument limit, so jq never ran: line 1994: /usr/bin/jq: Argument list too long. The error printed at the top of every session-start summary since the upgrade, and the contribution check got no input.

What changed

• The contribution-input branch now writes the backlog and task JSON to files in the script's existing temporary transport directory and reads them with --slurpfile, the same pattern the full snapshot path already uses a few lines below. The existing EXIT trap removes the directory.
• The task list moves the same way, since it grows with the fleet.
• New regression test test_contribution_input_survives_oversized_backlog in tests/fm-contributions.test.sh builds an 800-record synthetic backlog whose JSON exceeds 128 KiB, and checks every record and the task list survive. It fails against the old code.

Evidence

• no-mistakes pipeline: review, test, document and lint passed; push done. Its PR step does not support this Forgejo remote, so this PR was opened by hand.
• On this home's real backlog, the fixed script exits 0 with 830,156 bytes of JSON; main still fails with the error above. No temporary directory is left behind.
• bin/fm-lint.sh (ShellCheck, actionlint) clean; all 45 contribution tests pass.

Out of scope

No other snapshot or startup behaviour changes.

**Story:** PYR0D-351 - Firstmate: session-start fleet snapshot fails with "Argument list too long" on a large backlog ## What was wrong `bin/fm-fleet-snapshot.sh --contribution-input` handed the whole backlog JSON to jq as a command-line argument (`jq -n --argjson backlog "$BACKLOG_JSON" ...`). On this home's backlog that one argument is far past the kernel's 128 KiB single-argument limit, so jq never ran: `line 1994: /usr/bin/jq: Argument list too long`. The error printed at the top of every session-start summary since the upgrade, and the contribution check got no input. ## What changed - The contribution-input branch now writes the backlog and task JSON to files in the script's existing temporary transport directory and reads them with `--slurpfile`, the same pattern the full snapshot path already uses a few lines below. The existing EXIT trap removes the directory. - The task list moves the same way, since it grows with the fleet. - New regression test `test_contribution_input_survives_oversized_backlog` in `tests/fm-contributions.test.sh` builds an 800-record synthetic backlog whose JSON exceeds 128 KiB, and checks every record and the task list survive. It fails against the old code. ## Evidence - no-mistakes pipeline: review, test, document and lint passed; push done. Its PR step does not support this Forgejo remote, so this PR was opened by hand. - On this home's real backlog, the fixed script exits 0 with 830,156 bytes of JSON; main still fails with the error above. No temporary directory is left behind. - `bin/fm-lint.sh` (ShellCheck, actionlint) clean; all 45 contribution tests pass. ## Out of scope No other snapshot or startup behaviour changes.

john added 1 commit 2026-09-30 23:25:11 +00:00

PYR0D-351: Pass the contribution-input backlog to jq as files, not arguments 58c5f7d99b

john added 1 commit 2026-09-30 23:49:43 +00:00

PYR0D-351: Fail the contribution input loudly when jq assembly fails c109d2ecf3

john merged commit a98c865717 into main 2026-10-01 01:19:18 +00:00

john referenced this pull request from a commit 2026-10-01 01:19:19 +00:00

PYR0D-351: Pass the contribution-input backlog to jq as files, not arguments (#40)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

john/firstmate!40

No description provided.